Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/sagemaker_workforce - new resource #20065

Merged
merged 9 commits into from
Jul 28, 2021
Merged

r/sagemaker_workforce - new resource #20065

merged 9 commits into from
Jul 28, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jul 4, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSagemakerWorkforce_'
--- PASS: TestAccAWSSagemakerWorkforce_cognitoConfig (48.65s)
--- PASS: TestAccAWSSagemakerWorkforce_oidcConfig (72.97s)
--- PASS: TestAccAWSSagemakerWorkforce_sourceIpConfig (113.18s)
--- PASS: TestAccAWSSagemakerWorkforce_disappears (44.20s)

@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Jul 4, 2021
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Jul 4, 2021
@DrFaust92
Copy link
Collaborator Author

No tagging support added because workforce tags cant be listed:

Error: error listing tags for SageMaker Workforce (xxxx): ValidationException: Invalid resource type: workforce

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/cognito labels Jul 4, 2021
@DrFaust92 DrFaust92 marked this pull request as ready for review July 4, 2021 03:59
@DrFaust92 DrFaust92 mentioned this pull request Jul 9, 2021
Merged
ewbankkit
ewbankkit approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSCognitoUserPoolClient_basic\|TestAccAWSSagemakerWorkforce_'                            
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCognitoUserPoolClient_basic\|TestAccAWSSagemakerWorkforce_ -timeout 180m
=== RUN   TestAccAWSCognitoUserPoolClient_basic
=== PAUSE TestAccAWSCognitoUserPoolClient_basic
=== RUN   TestAccAWSSagemakerWorkforce_cognitoConfig
--- PASS: TestAccAWSSagemakerWorkforce_cognitoConfig (30.19s)
=== RUN   TestAccAWSSagemakerWorkforce_oidcConfig
--- PASS: TestAccAWSSagemakerWorkforce_oidcConfig (33.80s)
=== RUN   TestAccAWSSagemakerWorkforce_sourceIpConfig
--- PASS: TestAccAWSSagemakerWorkforce_sourceIpConfig (49.04s)
=== RUN   TestAccAWSSagemakerWorkforce_disappears
--- PASS: TestAccAWSSagemakerWorkforce_disappears (19.42s)
=== CONT  TestAccAWSCognitoUserPoolClient_basic
--- PASS: TestAccAWSCognitoUserPoolClient_basic (17.20s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	152.893s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSCognitoUserPoolClient_basic\|TestAccAWSSagemakerWorkforce_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCognitoUserPoolClient_basic\|TestAccAWSSagemakerWorkforce_ -timeout 180m
=== RUN   TestAccAWSCognitoUserPoolClient_basic
=== PAUSE TestAccAWSCognitoUserPoolClient_basic
=== RUN   TestAccAWSSagemakerWorkforce_cognitoConfig
    provider_test.go:1146: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker Workforce (tf-acc-test-2098246008099439449): UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: a78f0963-cdbb-433e-8093-653c6f43235a
        
          with aws_sagemaker_workforce.test,
          on terraform_plugin_test.tf line 17, in resource "aws_sagemaker_workforce" "test":
          17: resource "aws_sagemaker_workforce" "test" {
        
--- SKIP: TestAccAWSSagemakerWorkforce_cognitoConfig (16.41s)
=== RUN   TestAccAWSSagemakerWorkforce_oidcConfig
    provider_test.go:1146: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker Workforce (tf-acc-test-3259430020211855424): UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 8bbc7e4f-523c-4532-ab0a-51ede57de223
        
          with aws_sagemaker_workforce.test,
          on terraform_plugin_test.tf line 17, in resource "aws_sagemaker_workforce" "test":
          17: resource "aws_sagemaker_workforce" "test" {
        
--- SKIP: TestAccAWSSagemakerWorkforce_oidcConfig (12.82s)
=== RUN   TestAccAWSSagemakerWorkforce_sourceIpConfig
    provider_test.go:1146: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker Workforce (tf-acc-test-8574498970572914749): UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 46e1a5a4-d7d8-45a6-addf-6d73f5151f79
        
          with aws_sagemaker_workforce.test,
          on terraform_plugin_test.tf line 17, in resource "aws_sagemaker_workforce" "test":
          17: resource "aws_sagemaker_workforce" "test" {
        
--- SKIP: TestAccAWSSagemakerWorkforce_sourceIpConfig (13.28s)
=== RUN   TestAccAWSSagemakerWorkforce_disappears
    provider_test.go:1146: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker Workforce (tf-acc-test-4644955007703507201): UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 5cc1a6c7-94f4-45fc-ae48-a9f47290ab6a
        
          with aws_sagemaker_workforce.test,
          on terraform_plugin_test.tf line 17, in resource "aws_sagemaker_workforce" "test":
          17: resource "aws_sagemaker_workforce" "test" {
        
--- SKIP: TestAccAWSSagemakerWorkforce_disappears (13.89s)
=== CONT  TestAccAWSCognitoUserPoolClient_basic
--- PASS: TestAccAWSCognitoUserPoolClient_basic (23.79s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	83.245s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit ee27cf9 into hashicorp:main Jul 28, 2021
@github-actions github-actions bot added this to the v3.52.0 milestone Jul 28, 2021
@DrFaust92 DrFaust92 deleted the r/sagemaker_workforce branch July 28, 2021 20:02
@github-actions
Copy link

This functionality has been released in v3.52.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.52.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DrFaust92 @ewbankkit